Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CircleCI with CF Worker #8090

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

Carlgo11
Copy link
Member

@Carlgo11 Carlgo11 commented Jun 9, 2024

Over the weekend, I rewrote the tests run by CircleCI in JavaScript for Cloudflare Workers.
As GitHub doesn't allow secrets to be used for workflows deployed by pull requests, a middleman such as CircleCI or Cloudflare needs to be used.

This PR adds a new workflow to this repository, which sends a GET request to the Cloudflare Worker upon PR changes. The Worker then fetches the modified files for the PR and runs tests using the file data.

Currently, the script validates the SimilarWeb rank and Facebook page handles. I had to drop the Twitter handle check because Elon made username searches a premium API feature 馃檮

PR Validator code: 2factorauth/pr-validator

@Carlgo11 Carlgo11 added the enhancement Issue/PR contains enhancements to the overall code of the site. label Jun 9, 2024
@hkamran80
Copy link
Member

hkamran80 commented Jun 9, 2024

I had to drop the Twitter handle check because Elon made username searches a premium API feature 馃檮

Of course he did.

Does the ::error ... response show up in the files view?

@Carlgo11
Copy link
Member Author

Carlgo11 commented Jun 9, 2024

Does the ::error ... response show up in the files view?

I haven't tested it, but it should show up in the files view as cURL just sends the response to /dev/stdout, and GitHub then interprets that.

@hkamran80 hkamran80 merged commit 66eb5fb into 2factorauth:master Jun 9, 2024
3 checks passed
@hkamran80
Copy link
Member

Looks good to me!

@Carlgo11 Carlgo11 deleted the pr-validator branch June 9, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants