Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #5720

Merged
merged 9 commits into from
Aug 25, 2021
Merged

Conversation

Carlgo11
Copy link
Member

No description provided.

@Carlgo11 Carlgo11 mentioned this pull request May 26, 2021
15 tasks
@phallobst phallobst added the enhancement Issue/PR contains enhancements to the overall code of the site. label May 27, 2021
Copy link
Member

@phallobst phallobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the creation of _data/all.json is part of the instructions, that file should also be included in .gitignore, I guess.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Arun Pattni <[email protected]>
README.md Outdated Show resolved Hide resolved
@phallobst

This comment has been minimized.

Copy link
Member

@ApCoder123 ApCoder123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webp installation instructions can also probably be removed from the macOS section


Ubuntu/WSL/MacOS:
```BASH
docker run -p 4000:4000 -v $(pwd):/twofactorauth 2factorauth/twofactorauth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even when pulling 2factorauth/twofactorauth:latest, I still get an error when running this command. It looks like the Dockerfile from #5546 is being used rather than the most recent one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've been meaning to setup a workflow for that. Right now it is pushed manually as Docker removed their GitHub integration for free accounts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webp instructions are now gone

@Carlgo11 Carlgo11 mentioned this pull request Aug 24, 2021
@ApCoder123 ApCoder123 merged commit 24db39a into 2factorauth:master Aug 25, 2021
@Carlgo11 Carlgo11 deleted the update-readme branch September 4, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants