Minor styling fixes #4802
Merged
Minor styling fixes #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README
dsoegijono
added
the
enhancement
Add babel-minify to macos instructions
|
I just noticed that the sticky table headings only work in Firefox again, but not in Chrome (+Chromium-based browsers) - see also #4746. Can you fix that as well? I was unsuccessful. |
Carlgo11
approved these changes
Jun 12, 2020
|
@Carlgo11 Not necessary exactly. Do you manually remove it after @phallobst I can try looking into it but maybe in a separate PR? |
|
The column width are fixed by this. I'm okay with another PR for the "sticky" bug. |
phallobst
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README
Need to
servebefore it's accessibleDesktop table width
The column widths were set on the
<td>for icons only, so during search if a section has only non-tfa listed, the width wasn't set. This ensures the table headers width is fixed.Before
After
Site name overlaps exception icon
Before
After
