Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build status image source #4458

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

Carlgo11
Copy link
Member

Updated the build status image since we no longer use Travis.

@Carlgo11 Carlgo11 added the enhancement Issue/PR contains enhancements to the overall code of the site. label Dec 21, 2019
@Carlgo11 Carlgo11 changed the title Update build source Update build status image source Dec 30, 2019
@phallobst
Copy link
Member

Can this be something other than "passing" if each PR has to pass the check before it is merged?

@Carlgo11
Copy link
Member Author

@phallobst uhm not really. I can’t change the status messages

@phallobst
Copy link
Member

I think you misunderstood. What I meant was:

Is it possible to have a situation where the build status is something other than "passing", given that each PR individually has to pass the checks before merging? If not, that status is not really useful.

@Carlgo11
Copy link
Member Author

Ah no this build status is for the master branch. So unless we merge a PR that breaks our site it shouldn’t fail.

@dsoegijono dsoegijono merged commit 461ef3f into 2factorauth:master Apr 14, 2020
@Carlgo11 Carlgo11 deleted the update-readme branch May 20, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants