Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kss version #258

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Fix kss version #258

merged 2 commits into from
Jun 4, 2020

Conversation

nredoulez
Copy link
Contributor

KSS is no longer on beta and its v3 has been released.
This induced a malfunction of the symbols on Colette.

I also added the method to test our local version of colette-kss-builder with Colette on the readme, which can be very useful!

@nredoulez nredoulez requested a review from j0k3r June 3, 2020 15:25
@nredoulez nredoulez self-assigned this Jun 3, 2020
package-lock.json Outdated Show resolved Hide resolved
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you should rename your last commit from 5.5.1 to 5.4.1 to avoid confusion in commits history once merged

@nredoulez
Copy link
Contributor Author

I really thought I did!

@nredoulez nredoulez merged commit 17c98f5 into 20minutes:master Jun 4, 2020
@nredoulez nredoulez deleted the fix/kss-version branch June 4, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants