Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git binary needs to be installed also #141

Closed
sotcsa opened this issue May 31, 2021 · 5 comments · Fixed by #142
Closed

git binary needs to be installed also #141

sotcsa opened this issue May 31, 2021 · 5 comments · Fixed by #142

Comments

@sotcsa
Copy link

sotcsa commented May 31, 2021

Issue

Git is not installed but yarn install tries to use it.

How to reproduce:

Fresh git clone
docker-compse up

The log shows the error

Step 5/14 : COPY ./package.json .
 ---> 58f5e723404f
Step 6/14 : COPY ./yarn.lock .
 ---> ff8e79f2ced8
Step 7/14 : RUN yarn install
 ---> Running in 8b8661f0c537
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
error Couldn't find the binary git

Suggested fix:

add git to list of installable packages:

shieldy/Dockerfile

Line 15 in afb7e31

yarn

@backmeupplz
Copy link
Contributor

@PeterDaveHello is there any chance you can help with this?

@PeterDaveHello
Copy link
Contributor

Well ... it's caused by 9378f0b and the following 6b70ed7, 75d6523, I'd send a pull request to add git into Docker image.

PeterDaveHello added a commit to PeterDaveHello/shieldy that referenced this issue May 31, 2021
@PeterDaveHello
Add git to Docker image, fix 1inch#141
369e017 
Reference commits:

- 9378f0b
- 6b70ed7
- 75d6523
@PeterDaveHello PeterDaveHello mentioned this issue May 31, 2021
Merged
@PeterDaveHello
Copy link
Contributor

#142 should fix it

@backmeupplz
Copy link
Contributor

@PeterDaveHello thank you a lot for the fixes! :)

@sotcsa
Copy link
Author

sotcsa commented May 31, 2021

Many thanks, a really quick fix, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add git to Docker image PeterDaveHello/shieldy
3 participants
@sotcsa @backmeupplz @PeterDaveHello