[WIP] custom packet serializer implementation #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c3t3a
reviewed
Apr 17, 2024
shenjackyuanjie
force-pushed
the
message_pack
branch
from
21a6407
to
9529d64
Compare
revert requirement changes
shenjackyuanjie
force-pushed
the
message_pack
branch
from
9529d64
to
cf5ed44
Compare
|
to be clear, the code is not done, and there is some leftover need to be cleanup |
|
bad news, I found my implment should be at socketio packet …… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yea, here I am again
gogogo!
will fix #406