Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify result print format to be ignore-obj-size-aware #66

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

haochengxia
Copy link
Contributor

@haochengxia haochengxia commented Jun 19, 2024

When print simulation results (except for [info]), unify the format with the logic as follows:
if ignore-obj-size=False, cache size is xxB/KiB/MiB ... (align with common.py)
else, cache size is a pure number (the number of objects).

# multi sim is ignore-obj-size-aware in the print format, however, single is not
$ ../_build/bin/cachesim ../data/cloudPhysicsIO.vscsi vscsi s3fifo 0.1 --ignore-obj-size 0
../data/cloudPhysicsIO.vscsi S3FIFO-0.1000-2 cache size   194MiB,           113872 req, miss ratio 0.7273, throughput 5.87 MQPS
$ ../_build/bin/cachesim ../data/cloudPhysicsIO.vscsi vscsi s3fifo 0.1 --ignore-obj-size 1
../data/cloudPhysicsIO.vscsi S3FIFO-0.1000-2 cache size     5KiB,           113872 req, miss ratio 0.7525, throughput 5.87 MQPS

besides, when the size is less than 1KiB, no unit will also be confusing so we can add a unit "B" (Byte) for the case --ignore-obj-size 0.

$ ../_build/bin/cachesim ../data/cloudPhysicsIO.vscsi vscsi s3fifo 0.0000001 --ignore-obj-size 0
../data/cloudPhysicsIO.vscsi S3FIFO-0.1000-2 cache size      202,           113872 req, miss ratio 1.0000, throughput 8.51 MQPS

After modification,

$ ../_build/bin/cachesim ../data/cloudPhysicsIO.vscsi vscsi s3fifo 0.1 --ignore-obj-size 1
../data/cloudPhysicsIO.vscsi S3FIFO-0.1000-2 cache size     4897,           113872 req, miss ratio 0.7525, throughput 6.81 MQPS

$ ../_build/bin/cachesim ../data/cloudPhysicsIO.vscsi vscsi s3fifo 0.0000001 --ignore-obj-size 0
../data/cloudPhysicsIO.vscsi S3FIFO-0.1000-2 cache size     202B,           113872 req, miss ratio 1.0000, throughput 11.71 MQPS

@1a1a11a 1a1a11a merged commit 3abee5f into 1a1a11a:develop Jun 19, 2024
2 checks passed
@haochengxia haochengxia deleted the print_result branch June 20, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants