Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Feature: enable multiple snapshots #4

Merged
merged 20 commits into from
Mar 19, 2019
Merged

Conversation

adamsilverstein
Copy link

@adamsilverstein adamsilverstein commented Mar 4, 2019

Addresses #3.

@adamsilverstein adamsilverstein changed the title Feature: enable multiple snapshots [WIP]: Feature: enable multiple snapshots Mar 4, 2019
@jeffpaul jeffpaul added the enhancement New feature or request label Mar 4, 2019
@jeffpaul jeffpaul added this to the 1.0.0 milestone Mar 4, 2019
@adamsilverstein adamsilverstein changed the title [WIP]: Feature: enable multiple snapshots Feature: enable multiple snapshots Mar 6, 2019
@adamsilverstein
Copy link
Author

This worked in my initial testing. Going to test with Distributor.

@tlovett1
Copy link
Member

tlovett1 commented Mar 7, 2019

@adamsilverstein looking through the docs and I'm a bit confused on the logic. If I run the run command with no arguments and snapshot_id and snapshots are both present in wpassure.json what happens?

@adamsilverstein
Copy link
Author

looking through the docs and I'm a bit confused on the logic.

I'll work on improving the docs to clear this up. Open to ideas about HOW this should work, my goal is to have it backwards compatible with the existing system, eg adding a snapshots array is completely optional.

If I run the run command with no arguments and snapshot_id and snapshots are both present in wpassure.json what happens?

Here is what I propose:

  • When snapshots is not defined: no change to current behavior.
  • When snapshots is defined: the run command with no arguments runs the tests against all of the snapshots in the array, ignoring the snapshot_id
  • Running with tests with --save --local follows the current behavior: testing, then pushing the local snaphot up as a new image, and putting this new id in snapshot_id.
  • Although the developer could add the new id to the snapshots array manually, we can also enable a new command --add="[Snapshot Name]"that does this automatically, eg. something like: ./vendor/bin/wpacceptance run --local --save --add="WordPress 5.1 plus Gutenberg 5.2". this would run the tests, save the snapshot, set the snapshot_id and add a new entry in the snapshots array.

@tlovett1 Any comments questions?

@adamsilverstein
Copy link
Author

@tlovett1 tlovett1 merged commit fca517d into master Mar 19, 2019
@jeffpaul jeffpaul deleted the feature/multiple-snapshots branch March 12, 2020 18:43
@jeffpaul jeffpaul modified the milestones: 1.0.0, 0.16.10 May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request needs-testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants