Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for core auto-updates for registered sites #726

Merged
merged 8 commits into from
Jun 3, 2022
Merged

Conversation

dhanendran
Copy link
Member

Description of the Change

Added support for plugin auto-update for registered user.

Possible Drawbacks

After updating to this version, this change might not be visible immediately as WP has already collected the data for existing plugins and stored it in transient for 12 hours (I guess). So either we need to manually delete the transient or wait for 12 hours.

Verification Process

  • After checking out to this branch, manually delete the transient.
  • _site_transient_update_plugins meta key name in sitemeta table needs to be deleted

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#656

@jeffpaul jeffpaul requested a review from dkotter March 3, 2021 14:58
@jeffpaul jeffpaul added this to the 1.6.3 milestone Mar 3, 2021
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 3, 2021
includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
@jeffpaul jeffpaul modified the milestones: 1.6.3, 1.7.0 Mar 10, 2021
@dhanendran
Copy link
Member Author

@dkotter using an update checker library is a great suggestion. I have updated my code to use them now.

@jeffpaul jeffpaul requested a review from dkotter March 12, 2021 16:29
includes/settings.php Outdated Show resolved Hide resolved
@dkotter
Copy link
Collaborator

dkotter commented Mar 15, 2021

@dhanendran This looks a lot cleaner now, using that update class. I've left one minor comment but otherwise looks good to me code-wise. Have you tested this with the new approach and are seeing auto-updates work? I tried testing locally but I could never get auto-updates to fire, though may have just not waited long enough.

@dhanendran
Copy link
Member Author

@dkotter looks like similar code already present in https://github.com/10up/distributor/blob/develop/distributor.php#L156-L188. Not sure why it is not working though, I will check the existing implementation first.

@jeffpaul
Copy link
Member

@dhanendran any updates on your research on this topic?

@dhanendran
Copy link
Member Author

@jeffpaul unfortunately no, as I was busy with other project priorities. I will try to check this in next couple of weeks.

@jeffpaul jeffpaul linked an issue May 6, 2022 that may be closed by this pull request
@sksaju sksaju self-assigned this May 17, 2022
@jeffpaul jeffpaul requested a review from dkotter May 19, 2022 01:39
@sksaju
Copy link
Member

sksaju commented May 24, 2022

This PR is ready for your review @dkotter @jeffpaul

Screenshot 2022-05-25 at 4 38 39 AM

@dkotter dkotter merged commit aa36d6c into develop Jun 3, 2022
@dkotter dkotter deleted the issue-656 branch June 3, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for core auto-updates for registered sites
4 participants