Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show loading indicator after submitting an external connection URL #601

Merged
merged 5 commits into from
Jun 16, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Fixes #595.

Show a spinner and a message indicates that we're checking the connection.

Benefits

Make the UI more interactive.

Possible Drawbacks

Verification Process

Create a new connection using Auth Wizard, see the spinner and message after submitting the external site URL.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@dinhtungdu dinhtungdu requested a review from helen June 13, 2020 03:38
@dinhtungdu dinhtungdu self-assigned this Jun 13, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jun 15, 2020
Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one string tweak and one other thing I noticed - the checking message shows even with an empty URL and then gets stuck there. I think it probably shouldn't show until it's past the URL checking a few lines later.

includes/classes/Authentications/WordPressBasicAuth.php Outdated Show resolved Hide resolved
@dinhtungdu
Copy link
Contributor Author

@helen Thanks for the review! Now the status only shows after URL and title are validated.

@dinhtungdu dinhtungdu requested a review from helen June 15, 2020 23:33
Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now!

@helen helen merged commit f1167a3 into develop Jun 16, 2020
@helen helen deleted the fix/595 branch June 16, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth wizard: No indicator that anything is happening after submitting an external connection URL
3 participants