Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use button in external connection URL. #565

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

samikeijonen
Copy link
Contributor

Fixes #553

Description of the Change

Use button instead of empty <a> without href in external connection URL suggestion.

Benefits

Automatic keyboard support.

Possible Drawbacks

None.

Verification Process

  1. Edit external connection.
  2. Locate External Connection URL field.
  3. Add test URL like http:https://testurl.test.
  4. Notice suggestion text below field, "Did you mean: http:https://testurl.test/wp-json" .
  5. Verify that you can navigate to that URL button and select it to populate link in the field.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#553

@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 18, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 18, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked great!

@dkotter dkotter merged commit 6674935 into 10up:develop Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In “External Connection URL”, there is no way to focus on a link with a keyboard
4 participants