Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak allowed to push markup #560

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Tweak allowed to push markup #560

merged 1 commit into from
Apr 10, 2020

Conversation

samikeijonen
Copy link
Contributor

Fixes #552.

Description of the Change

Change the markup used in "Roles Allowed to Push" checkboxes. This is part of External connection view.

Benefits

Screen reader will announce legend "Roles Allowed to Push" when selecting checkboxes.

Possible Drawbacks

Is there any JS behind the scenes when checking checkboxes that could break with markup change.

Verification Process

Tested with Voiceover by selecting checkboxes.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#552

@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 18, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 18, 2020
dinhtungdu
dinhtungdu approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dkotter dkotter merged commit 6a36a74 into 10up:develop Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@samikeijonen samikeijonen

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Roles Allowed to Push markup enhancements
4 participants
@samikeijonen @dinhtungdu @dkotter @jeffpaul