Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplication of terms #262

Merged
merged 5 commits into from
Jul 18, 2019
Merged

Fix duplication of terms #262

merged 5 commits into from
Jul 18, 2019

Conversation

arsendovlatyan
Copy link
Contributor

@arsendovlatyan arsendovlatyan commented Nov 28, 2018 •
edited
Loading

Fix duplication of terms with every update, in case if term slug is custom set in source website and term creation is not disabled/skipped with hooks in destination. #261

@arsendovlatyan arsendovlatyan mentioned this pull request Nov 28, 2018
Closed
@arsendovlatyan
fix term hierarchy in destination when parent term was not mapped 10u…
2631535 
…p#219

also, remove parent them, if it's removed in source
@arsendovlatyan arsendovlatyan mentioned this pull request Nov 28, 2018
Open
@arsendovlatyan arsendovlatyan mentioned this pull request Feb 5, 2019
Closed
arsendovlatyan referenced this pull request in avag-novembit/distributor-adapted Jun 5, 2019
@avag-novembit
first commit
9a97a74
@jeffpaul
Copy link
Member

jeffpaul commented Jun 5, 2019

@arsendovlatyan it looks like the build failed on these changes, mind giving those a review to try and ensure this build passes?

@jeffpaul jeffpaul added this to the Future Release milestone Jun 5, 2019
@jeffpaul jeffpaul added the needs:feedback This requires reporter feedback to better understand the request. label Jun 5, 2019
@madmax3365 madmax3365 mentioned this pull request Jun 6, 2019
Merged
@jeffpaul
Copy link
Member

jeffpaul commented Jun 6, 2019

Resolves #325.

@jeffpaul
Copy link
Member

jeffpaul commented Jun 6, 2019

@adamsilverstein @dkotter if either of you have time to review this that would be great, thanks!

@jeffpaul jeffpaul added type:bug Something isn't working. and removed needs:feedback This requires reporter feedback to better understand the request. labels Jun 6, 2019
@jeffpaul jeffpaul modified the milestones: Future Release, 1.5.0 Jun 6, 2019
@helen
Copy link
Contributor

helen commented Jul 18, 2019

I cannot figure out why it's reporting whitespace at the end of line 447 and not reporting the warnings at line 490 that I get locally. Merging, will deal with it separately if necessary.

@helen helen merged commit 16f2f6d into 10up:develop Jul 18, 2019
@arsendovlatyan arsendovlatyan deleted the fix/duplication-of-term branch July 18, 2019 15:13
@arsendovlatyan
Copy link
Contributor Author

Thank you very much @helen , will try to be more accurate with code and cover with tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@dkotter dkotter Awaiting requested review from dkotter

Assignees

@arsendovlatyan arsendovlatyan

Labels
type:bug Something isn't working.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arsendovlatyan @jeffpaul @helen