Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various changes (WORK IN PROGRESS) #243

Merged
merged 61 commits into from
May 30, 2021
Merged

various changes (WORK IN PROGRESS) #243

merged 61 commits into from
May 30, 2021

Conversation

DavidBJaffe
Copy link
Contributor

@DavidBJaffe DavidBJaffe commented May 29, 2021 •
edited

GUI

  • help page in GUI now refers to bit.ly/enclone
  • do initial ssh to see if the firewall can be crossed at all, so that failure if not is gracious
  • make horizontal rule nicer
  • retry server launch after sleeping one second if it fails the first time
  • rearchitect to put all the visualization code in its own crate
  • delete the react demo code
  • increase allowed test time from 137 to 171 seconds
    the delta is explained by the very annoying extra compile that occurs when testing, and the increased length of that
  • reduce font size in text input box so as to make longer commands more practical
  • for now, make the clonotype tables bold
  • add scroll_crash, which exhibits a GUI crash

OTHER

  • move some scripts to a new directory "scripts"
  • add test for a bug that occurred in customer data

David Jaffe added 22 commits May 29, 2021 06:30
rustfmt
eaca219
retry server attempt if it fails the first time
f3d62e9
update to do list and rustfmt
0afc834
rearchitect to put all the visualization code in one crate
469b73c
rustfmt
cab41d3
add to todo list
7d9284c
remove some unused dependencies
3c7d625
make ./test work, or at least almost
b011090
remove unneeded dependencies; ./test passes except 178 seconds
a7ff1d7
remove deps; ./test passes except for run time
5bec88a
remove deps; ./test passes except for run time
f586355
remove deps; ./test passes except for run time
b773a27
reduce deps and kill enclone_client; ./test passes except for run time
27f7bf3
remove deps; ./test passes except for run time
7fbdf44
remove deps; ./test passes except for run time
f5782f5
remove deps; ./test passes except for run time
2daf4ba
remove deps; ./test passes except for run time
a853a19
increase allowed test time from 137 to 171 seconds
9e6041c
move some scripts to a new directory "scripts"
9cf644a
add joke and add to todo list
3633432
reduce font size in text input box
be96145
add to todo list
435b478
@DavidBJaffe DavidBJaffe reopened this May 30, 2021
@DavidBJaffe DavidBJaffe merged commit 93969c0 into master May 30, 2021
@DavidBJaffe DavidBJaffe deleted the dj/162 branch May 30, 2021 16:31
adam-azarchs
adam-azarchs reviewed Sep 30, 2021
View reviewed changes
enclone_main/Cargo.toml
@@ -19,10 +19,6 @@ publish = false
# Please do not edit crate versions within this file. Instead edit the file master.toml
# in the root of the enclone repo.

[[bin]]
name = "enclone"
path = "src/bin/enclone.rs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change broke the jenkins builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-azarchs adam-azarchs adam-azarchs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavidBJaffe @adam-azarchs