Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor old test cases and write some more test cases for views #33

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

sumit4613
Copy link
Member

Hey, I just made a Pull Request!

Description

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Release note


@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #33 into master will increase coverage by 8.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   49.08%   57.71%   +8.62%     
==========================================
  Files          17       17              
  Lines         601      603       +2     
==========================================
+ Hits          295      348      +53     
+ Misses        306      255      -51     
Flag Coverage Δ
#unittests 57.71% <100.00%> (+8.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
drf_user/serializers.py 53.00% <100.00%> (+14.45%) ⬆️
drf_user/views.py 57.76% <100.00%> (+3.72%) ⬆️
drf_user/utils.py 22.98% <0.00%> (+7.25%) ⬆️
drf_user/managers.py 62.06% <0.00%> (+41.37%) ⬆️
__init__.py 77.41% <0.00%> (+41.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fce710...c4091e0. Read the comment docs.

@sumit4613 sumit4613 merged commit ee5760d into master Sep 13, 2020
@sumit4613 sumit4613 deleted the sumit/update-add-test-views branch September 13, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant