Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test case for LoginView #22

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Adds test case for LoginView #22

merged 2 commits into from
Sep 12, 2020

Conversation

iamdipanshusingh
Copy link
Member

@iamdipanshusingh iamdipanshusingh commented Sep 12, 2020

Hey, I just made a Pull Request!

Description

Adds test case for LoginView

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Release note

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #22 into master will increase coverage by 18.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   26.03%   44.77%   +18.73%     
===========================================
  Files          17       17               
  Lines         603      603               
===========================================
+ Hits          157      270      +113     
+ Misses        446      333      -113     
Flag Coverage Δ
#unittests 44.77% <ø> (+18.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
drf_user/serializers.py 38.54% <0.00%> (+38.54%) ⬆️
drf_user/views.py 47.20% <0.00%> (+47.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0a37f...00089ed. Read the comment docs.

Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sumit4613 sumit4613 merged commit 5d2e8ad into 101Loop:master Sep 12, 2020
@iamdipanshusingh iamdipanshusingh deleted the dipanshu/views_test/login branch September 12, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants