feat(deps): remove drfaddons dependency (Sourcery refactored) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.53%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
sumit4613
force-pushed
the
sumit/remove-drfaddons
branch
from
ea24813
to
f2c7f44
Compare
sourcery-ai
bot
force-pushed
the
sourcery/sumit/remove-drfaddons
branch
3 times, most recently
from
c8b305d
to
830e39b
Compare
sourcery-ai
bot
force-pushed
the
sourcery/sumit/remove-drfaddons
branch
from
830e39b
to
634c789
Compare
| custom_settings = getattr(settings, "USER_SETTINGS", None) | ||
|
|
||
| if custom_settings: | ||
| if custom_settings := getattr(settings, "USER_SETTINGS", None): |
There was a problem hiding this comment.
Function update_user_settings refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-193
to
-205
| user = self.get_user(attrs.get("prop"), attrs.get("destination")) | ||
| if user := self.get_user(attrs.get("prop"), attrs.get("destination")): | ||
| attrs["email"] = user.email | ||
| attrs["user"] = user | ||
|
|
||
| if not user: | ||
| else: | ||
| if attrs["is_login"]: | ||
| raise NotFound(_("No user exists with provided details")) | ||
| if "email" not in attrs.keys() and "verify_otp" not in attrs.keys(): | ||
| raise serializers.ValidationError( | ||
| _("Email field is compulsory while verifying a non-existing user's OTP.") | ||
| ) | ||
| else: | ||
| attrs["email"] = user.email | ||
| attrs["user"] = user | ||
|
|
There was a problem hiding this comment.
Function OTPSerializer.validate refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Swap if/else branches (
swap-if-else-branches)
Comment on lines
-331
to
-336
| user = self.get_user(attrs.get("email")) | ||
|
|
||
| if not user: | ||
| if user := self.get_user(attrs.get("email")): | ||
| return attrs | ||
| else: | ||
| raise NotFound(_("User with the provided email does not exist.")) | ||
|
|
||
| return attrs |
There was a problem hiding this comment.
Function PasswordResetSerializer.validate refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
| x_forwarded_for = request.META.get("HTTP_X_FORWARDED_FOR") | ||
| if x_forwarded_for: | ||
| if x_forwarded_for := request.META.get("HTTP_X_FORWARDED_FOR"): |
There was a problem hiding this comment.
Function get_client_ip refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-254
to
+253
| match = re.match(r"^[6-9]\d{9}$", str(mobile)) | ||
| match = re.match(r"^[6-9]\d{9}$", mobile) |
There was a problem hiding this comment.
Function is_mobile_valid refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #208 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
sumit/remove-drfaddonsbranch, then run:Help us improve this pull request!