Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for windows #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NaveenGokavarapu19
Copy link

Hey, I just made a Pull Request!

Description

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 馃槃).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Release note


@sumit4613 sumit4613 self-requested a review September 20, 2021 12:32
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #119 (1e965df) into master (75d06fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          20       20           
  Lines         649      649           
=======================================
  Hits          621      621           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 75d06fd...1e965df. Read the comment docs.

Copy link
Member

@iamhssingh iamhssingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge the steps in the already existing one adding a clause saying. For Windows user: run following addition steps
@sumit4613


5) After Completing development work. Run command Set-ExecutionPolicy -ExecutionPolicy Undefined -Scope CurrentUser.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have some final conclusion stating what next steps the user should follow.


2) clone the git repo using command git clone [email protected]:101loop/drf-user.git or fork it and then clone the using the url of fork

3) Run py -m pip install --user virtualenv to install virtualenv library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3) Run py -m pip install --user virtualenv to install virtualenv library
3) Run py -m pip install --user virtualenv to install virtualenv library


1) Download python from microsoft store

2) clone the git repo using command git clone [email protected]:101loop/drf-user.git or fork it and then clone the using the url of fork
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this step and refer it to already existing step



Note: The command Set execution policy allows execution of remote scripts. Please remove permissions immediately after work to avoid security issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NaveenGokavarapu19 You forgot to close the section using ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants