Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Mint tx v1 #384

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Mint tx v1 #384

merged 8 commits into from
Jan 17, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jan 16, 2023

Usage related changes

Development related changes

  • Introduce and predeploy a ChargeableAccount that will hold a lot of funds and which will be charged for minting
  • Refactor account utilities
    • Create starknet_devnet/account_util.py
    • Move existing testing utilities there and import them
    • Needed because starknet_devnet needed a way to sign txs
    • Extract balance setting logic to set_balance
  • In a few places, replace decimal integer literals with hex (it's shorter and more common to see them as hex)

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@FabijanC FabijanC marked this pull request as draft January 16, 2023 15:06
@FabijanC FabijanC marked this pull request as ready for review January 16, 2023 15:34
@FabijanC FabijanC requested a review from mikiw January 16, 2023 15:38
@FabijanC FabijanC requested a review from mikiw January 17, 2023 12:28
@FabijanC FabijanC merged commit b6947da into master Jan 17, 2023
@FabijanC FabijanC deleted the mint-tx-v1 branch January 17, 2023 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if POST /mint is using transaction version 0
2 participants