Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Store L1L2 handle transactions #319

Merged
merged 16 commits into from
Oct 27, 2022
Merged

Store L1L2 handle transactions #319

merged 16 commits into from
Oct 27, 2022

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Oct 24, 2022 •
edited
Loading

Development related changes

  • Now L1<>L2 transactions will be executed in starknet wrapper and will be included in blocks

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@mikiw mikiw marked this pull request as draft October 24, 2022 14:28
@mikiw mikiw linked an issue Oct 24, 2022 that may be closed by this pull request
No transaction created for l1 -> l2 transactions #141
Closed
@mikiw mikiw marked this pull request as ready for review October 25, 2022 14:49
@mikiw mikiw requested a review from FabijanC October 25, 2022 14:49
FabijanC
FabijanC suggested changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR supposed to fix two things:

  1. L1_HANDLER executions not being stored
  2. Blocks not holding L2 to L1 messages or events (not sure anymore)

Are they both fixed? Are they properly tested?

test/test_postman.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/postman_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/postman_wrapper.py Show resolved Hide resolved
starknet_devnet/postman_wrapper.py Show resolved Hide resolved
@mikiw
Copy link
Contributor Author

mikiw commented Oct 26, 2022 •
edited
Loading

Is this PR supposed to fix two things:

  1. L1_HANDLER executions not being stored
  2. Blocks not holding L2 to L1 messages or events (not sure anymore)

Are they both fixed? Are they properly tested?

@FabijanC

  1. Yes that is fixed.
  2. Because now executions are stored, events are also stored.

Regarding "Blocks not holding L2 to L1 messages" I said that in my opinion, this doesn't work, you said that this should work so we can double-check it again and create a task.

mikiw
mikiw commented Oct 26, 2022
View reviewed changes
test/test_block_number.py Show resolved Hide resolved
test/test_postman.py Outdated Show resolved Hide resolved
starknet_devnet/postman_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/postman_wrapper.py Show resolved Hide resolved
starknet_devnet/postman_wrapper.py Show resolved Hide resolved
@mikiw mikiw requested a review from FabijanC October 27, 2022 09:06
@FabijanC FabijanC changed the title L1l2 handle transactions starknet wrapper L1L2 handle transactions starknet wrapper Oct 27, 2022
@FabijanC FabijanC changed the title L1L2 handle transactions starknet wrapper Store L1L2 handle transactions Oct 27, 2022
@FabijanC FabijanC merged commit a057931 into master Oct 27, 2022
@FabijanC FabijanC deleted the l1l2-handle-transactions-starknet-wrapper branch October 27, 2022 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No transaction created for l1 -> l2 transactions
2 participants
@mikiw @FabijanC