Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Store contract on deploy_account tx #314

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Store contract on deploy_account tx #314

merged 1 commit into from
Oct 21, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Oct 20, 2022 •
edited
Loading

Usage related changes

Development related changes

  • Expand test/shared.py with code that adds the ABI of the account used by Starknet CLI (and also currently used in our tests to test the deploy account tx type)
  • Expand existing deploy_account test with a few code lines that assert that the account contract can be interacted with

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@FabijanC FabijanC marked this pull request as ready for review October 20, 2022 15:56
@FabijanC FabijanC requested a review from mikiw October 20, 2022 15:56
@FabijanC FabijanC merged commit 923d3da into master Oct 21, 2022
@FabijanC FabijanC deleted the fix-saving-account branch October 21, 2022 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeployAccount does not save contract to self.contracts
2 participants
@FabijanC @mikiw