Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix error format #312

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Fix error format #312

merged 5 commits into from
Oct 20, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Oct 19, 2022 •
edited
Loading

Usage related changes

Development related changes

  • Make code a required argument of StarknetDevnetException.
  • Modify imports to follow the order: 1) built-in, 2) third-party, 3) local

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@FabijanC FabijanC marked this pull request as ready for review October 20, 2022 09:52
@FabijanC FabijanC requested a review from mikiw October 20, 2022 09:53
mikiw
mikiw approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@FabijanC FabijanC merged commit 780eb38 into master Oct 20, 2022
@FabijanC FabijanC deleted the fix-error-format branch October 20, 2022 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@FabijanC @mikiw