Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix positional args for addInvokeTransaction #283

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Fix positional args for addInvokeTransaction #283

merged 3 commits into from
Sep 26, 2022

Conversation

gregoryguillou
Copy link
Contributor

@gregoryguillou gregoryguillou commented Sep 23, 2022

Usage related changes

This is definitely a bug in devnet that is not showing up in goerli (pathfinder). We should be able to call the RPC api with positional argument and those arguments should come in the right order, i.e. signature comes 2nd in the case of addInvokeTransaction. Check the v0.1.0 spec for details

I guess there is a good reason why you have set the signature back with None with both default and Optional. However, it prevents any positional arguments from working and you would want to comply to it. I assume Pathfinder requires you pass a an empty list if they do not want to provide a signature. The test cases are documented in #282

Development related changes

N/A

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes <- What you expect I do?
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing <- One test on L1/L2 is failing on my laptop. I assume it is unrelated and I am missing some setup/node version.

@FabijanC FabijanC changed the title fix positional args for addInvokeTransaction Fix positional args for addInvokeTransaction Sep 26, 2022
@FabijanC FabijanC self-requested a review September 26, 2022 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants