This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
Fix positional args for addInvokeTransaction #283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
This is definitely a bug in devnet that is not showing up in goerli (pathfinder). We should be able to call the RPC api with positional argument and those arguments should come in the right order, i.e. signature comes 2nd in the case of addInvokeTransaction. Check the v0.1.0 spec for details
I guess there is a good reason why you have set the signature back with None with both default and Optional. However, it prevents any positional arguments from working and you would want to comply to it. I assume Pathfinder requires you pass a an empty list if they do not want to provide a signature. The test cases are documented in #282
Development related changes
N/A
Checklist:
./scripts/format.sh
./scripts/lint.sh