Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Support linting; Add plugin-venv test #21

Merged
merged 7 commits into from
Dec 21, 2021
Merged

Support linting; Add plugin-venv test #21

merged 7 commits into from
Dec 21, 2021

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Dec 20, 2021

Usage

  • This PR contains no usage changes.

Dev

  • Adds a linting step to the CI/CD workflow:
    • Performed with pylint and configured through .pylintrc.
    • Make necessary changes to conform to the standards set by the linter.
  • Add testing with plugin using a venv:
    • So far only the dockerized plugin version was tested.
    • Dockerized and venv test are specified as separate steps in job test.
    • Rely on hardhat's --config option for specifying which config file to use.
  • Instead of running all tests in starknet-hardhat-example, run only quick-test.ts.

@FabijanC FabijanC merged commit 65de06b into master Dec 21, 2021
@FabijanC FabijanC deleted the lint+venv branch December 21, 2021 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants