Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Replace meinheld with gunicorn #207

Merged
merged 12 commits into from
Aug 8, 2022

Conversation

Solpatium
Copy link
Contributor

@Solpatium Solpatium commented Aug 3, 2022

Usage related changes

  1. Access log has the same format and is printed to stderr as it was before.
  2. No logs were changed.

Development related changes

  1. Replaced meinheld with gunicorn.

Reasons:

  1. Renamed debug script to match naming convention of others and name in README.
  2. Used poetry in debug script to use poetry environment with local dependenies.

Checklist:

  • No linter errors
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes - NA
  • Linked the issues which this PR resolves - NA
  • Updated the tests - NA
  • All tests are passing

@Solpatium Solpatium marked this pull request as ready for review August 3, 2022 13:45
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely meinheld was ready to be replaced with something documented and maintained; thanks for the PR and for fixing the other issues. I left a few notes.

pyproject.toml Outdated Show resolved Hide resolved
starknet_devnet/server.py Outdated Show resolved Hide resolved
starknet_devnet/server.py Show resolved Hide resolved
starknet_devnet/server.py Show resolved Hide resolved
@FabijanC
Copy link
Collaborator

FabijanC commented Aug 4, 2022

Sorry, there was an issue with the lock file, can you resolve the conflicts again?

@FabijanC FabijanC self-requested a review August 8, 2022 08:44
@FabijanC FabijanC merged commit 4b4f48b into 0xSpaceShard:master Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants