Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

support non-decimal float ex. scientific 1000e18 #171

Merged
merged 5 commits into from
Jul 12, 2022
Merged

support non-decimal float ex. scientific 1000e18 #171

merged 5 commits into from
Jul 12, 2022

Conversation

tabaktoni
Copy link
Contributor

@tabaktoni tabaktoni commented Jul 11, 2022 •
edited
Loading

Usage related changes

🐛 Fix - add support for non-decimal float @ base router - fix #170

Checklist:

  • No linter errors
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@tabaktoni tabaktoni requested a review from FabijanC July 11, 2022 18:16
FabijanC
FabijanC suggested changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test for this and expand the minting documentation by telling the users that passing integer numbers in scientific notation is supported.

starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 970c50d into master Jul 12, 2022
@FabijanC FabijanC deleted the fix/base-scientific-int branch July 12, 2022 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/mint fails on JS scientific notation for 'amount' property
2 participants
@tabaktoni @FabijanC