-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for use of fzf-lua instad of telescope #3
Conversation
Thanks for your contribution !! That was fast 😂. |
@Sonicfury, happy to help and answer any question, but I don't see any. |
lua/scretch/init.lua
Outdated
@@ -33,30 +34,51 @@ local function new_named() | |||
api.nvim_command(config.split_cmd .. ' ' .. scretch_name) | |||
end | |||
|
|||
local function get_search_args(backend) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there speficic reason why you created another function ? couldn't we have this directly in search() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 no. i think i had something a little more elegant planned, but in the end, the fzf telescope apis were too different.
lua/scretch/init.lua
Outdated
get_search_args(config.backend) | ||
end | ||
|
||
local function get_grep_args(backend, query) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
heh, I have been caught in a meeting and forgot to submit, my bad |
i found this plugin on [reddit](https://www.reddit.com/r/neovim/comments/1346sl5/plugin_scretch_easily_manage_scratch_files/?utm_source=share&utm_medium=web2x&context=3) and thought it looked useful. however, i couldn't use it as it depended on telescope, which i just migrated away from fixed in [#3](0xJohnnyboy/scretch.nvim#3)
This PR allows for the user to input a
backend
param to the config. It defaults to"telescope.builtin"
and keeps in inital implementation.If the user passes
"fzf-lua"
as an argumen to thebackend
param, this will be used instead of telescope.