-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail wazero integrate #1474
Open
storybehind
wants to merge
43
commits into
sprint-1.18
Choose a base branch
from
thumbnail-wazero-integrate
base: sprint-1.18
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/gosdk into thumbnail-wazero-integrate
installing rustc while for wasm binary
* added build.sh into iod, android, macos * fix and added build.sh into windows job.
…n/gosdk into thumbnail-wazero-integrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
API to generate thumbnail of given image. Accepts three parameters.
Thumbnail(img []byte, width, height int)
img
-> byte array of image,width
andheight
-> width and height of expected thumbnail image inpixels
,If it results in error, the second parameter (error) will be error message of string type.
Otherwise, the second parameter will always be null. The first parameter contains byte array of thumbnail image.
NOTE: The first parameter will be empty array if it's unsuccessful (e.g couldn't generate due to unsupported format). This can be used as a fallback mechanism to generate thumbnail in the frontend.
benchmark image.txt
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):