Sign upLogin

eidng8/sttbot

View on GitHub
Star

Showing 223 of 223 total issues

File MissionListTest.php has 624 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: JC
 * Date: 2016-11-18
Severity: Major
Found in tests/Wiki/Templates/MissionListTest.php - About 1 day to fix

Function imageInfo has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function imageInfo(array $files, $width = 0): array
    {
        if (empty($files)) {
            return [];
        }
Severity: Minor
Found in src/Wiki/Api/Query.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MissionTest.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: JC
 * Date: 2016-11-28
Severity: Minor
Found in tests/Wiki/Templates/Missions/MissionTest.php - About 3 hrs to fix

The class Mission has 11 public methods. Consider refactoring Mission to keep number of public methods under 10.
Open

class Mission extends Template
{
    private $advanced = false;

    /**
Severity: Minor
Found in src/Wiki/Templates/Mission.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class Parse has 12 public methods. Consider refactoring Parse to keep number of public methods under 10.
Open

class Parse
{
    use Properties {
        properties as traitProperties;
    }
Severity: Minor
Found in src/Wiki/Api/Parse.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class Indexer has 13 public methods. Consider refactoring Indexer to keep number of public methods under 10.
Open

class Indexer
{
    /**
     * @var array
     */
Severity: Minor
Found in src/Wiki/Indexer.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class CrewMember has 20 public methods. Consider refactoring CrewMember to keep number of public methods under 10.
Open

class CrewMember extends Model implements Hyperlink
{
    /**
     * Member name, also used in generating URI & page
     *
Severity: Minor
Found in src/Wiki/Models/CrewMember.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class CrewMember has an overall complexity of 57 which is very high. The configured complexity threshold is 50.
Open

class CrewMember extends Model implements Hyperlink
{
    /**
     * Member name, also used in generating URI & page
     *
Severity: Minor
Found in src/Wiki/Models/CrewMember.php by phpmd

The class MissionList has an overall complexity of 57 which is very high. The configured complexity threshold is 50.
Open

class MissionList extends WikiBase
{
    /**
     * List of all missions, organized by episodes/cadet
     *
Severity: Minor
Found in src/Wiki/Templates/MissionList.php by phpmd

The class IndexerTest has 11 public methods. Consider refactoring IndexerTest to keep number of public methods under 10.
Open

class IndexerTest extends TestCase
{
    /**
     * @var Wiki
     */
Severity: Minor
Found in tests/Wiki/IndexerTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class CrewList has 16 public methods. Consider refactoring CrewList to keep number of public methods under 10.
Open

class CrewList extends Template
{
    /**
     * Maximum skills statistics
     *
Severity: Minor
Found in src/Wiki/Templates/CrewList.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

CrewMember has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class CrewMember extends Model implements Hyperlink
{
    /**
     * Member name, also used in generating URI & page
     *
Severity: Minor
Found in src/Wiki/Models/CrewMember.php - About 2 hrs to fix

Function parseStep has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function parseStep(string $text): array
    {
        $columns = [
            'steptitle'  => 'name',
            'choice'     => 'alt',
Severity: Minor
Found in src/Wiki/Templates/Mission.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method testNew has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testNew()
    {
        $api = $this->newApiInstance();
        $text = (file_get_contents(
            static::DIR_SAMPLE . '/Crew-crew_member_list.txt'
Severity: Major
Found in tests/Wiki/Templates/CrewListTest.php - About 2 hrs to fix

MissionListTest has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class MissionListTest extends TestCase
{
    private $wiki;

    /**
Severity: Minor
Found in tests/Wiki/Templates/MissionListTest.php - About 2 hrs to fix

Method checkCadetMissionSteps has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function checkCadetMissionSteps(MissionModel $model)
    {
        $this->checkMissionStep(
            $model->steps[0],
            [
Severity: Major
Found in tests/Wiki/Templates/Missions/MissionTest.php - About 2 hrs to fix

Method checkCadetAdvMissionSteps has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function checkCadetAdvMissionSteps(MissionModel $model)
    {
        $this->checkMissionStep(
            $model->steps[0],
            [
Severity: Major
Found in tests/Wiki/Templates/Missions/MissionTest.php - About 2 hrs to fix

File MissionList.php has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: JC
 * Date: 2016-11-17
Severity: Minor
Found in src/Wiki/Templates/MissionList.php - About 2 hrs to fix

Method parseStepProp has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parseStepProp(
        string $key,
        string $values,
        string $advValues
    ) {
Severity: Major
Found in src/Wiki/Templates/Mission.php - About 2 hrs to fix

File Mission.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: JC
 * Date: 2016-11-20
Severity: Minor
Found in src/Wiki/Templates/Mission.php - About 2 hrs to fix
Severity
Category
Status
Source
Language