Fix matching with multiple name matchers. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was very subtly wrong before, and could skip input and names, causing incorrect strings to match (see the new tests for what didn't work properly before). The fix in this commit slows intra-line matching down considerably, as we now check each character individually when name matchers are used. If this turns out to be an actual bottleneck, this can be optimised.
|
Can you elaborate on what was wrong before? The new tests look good to me, but I'm uncertain what was causing the issue. |
|
When I added multiple name matching, I made a mistake when a "later" name matcher matched "earlier" in the text. In practise, this meant that some parts of some input were ignored. The new tests failed before but pass with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was very subtly wrong before, and could skip input and names, causing incorrect strings to match (see the new tests for what didn't work properly before).
The fix in this commit slows intra-line matching down considerably, as we now check each character individually when name matchers are used. If this turns out to be an actual bottleneck, this can be optimised.