Fix eddsa private key parsing bug #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eddsa private key is encoded as PEM(PKCS#8) format. While decoding the private key a bug was introduced to generate a new key from the encoded bytes. Fixed the issue by decoding the private key with same format.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 62.46% 62.53% +0.07%
==========================================
Files 79 79
Lines 7576 7584 +8
==========================================
+ Hits 4732 4743 +11
Misses 2541 2541
+ Partials 303 300 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
meling
requested changes
Mar 11, 2024
crypto/keygen/keygen.go
Outdated
| @@ -233,7 +233,17 @@ func ParsePrivateKey(buf []byte) (key hotstuff.PrivateKey, err error) { | |||
| case ecdsacrypto.PrivateKeyFileType: | |||
| key, err = x509.ParseECPrivateKey(b.Bytes) | |||
| case eddsa.PrivateKeyFileType: | |||
| key = ed25519.NewKeyFromSeed(b.Bytes[:32]) | |||
| //key = ed25519.NewKeyFromSeed(b.Bytes[:32]) | |||
crypto/keygen/keygen.go
Outdated
| //key = ed25519.NewKeyFromSeed(b.Bytes[:32]) | ||
| var genericKey any | ||
| var ok bool | ||
| genericKey, err = x509.ParsePKCS8PrivateKey(b.Bytes) |
There was a problem hiding this comment.
You can do:
genericKey, err :=To avoid the var genericKey any line above.
crypto/keygen/keygen.go
Outdated
| key = ed25519.NewKeyFromSeed(b.Bytes[:32]) | ||
| //key = ed25519.NewKeyFromSeed(b.Bytes[:32]) | ||
| var genericKey any | ||
| var ok bool |
There was a problem hiding this comment.
Move ok closer to its usage point.
meling
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eddsa private key is encoded as PEM(PKCS#8) format. While decoding the private key a bug was introduced to generate a new key from the encoded bytes.
Fixed the issue by decoding the private key with same format.