Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump libsql-client-go to fix downstream dep migration #808

Closed

Conversation

ghostwriternr
Copy link

go install started failing with the following error:

go install github.com/pressly/goose/v3/cmd/goose@latest
go: downloading nhooyr.io/websocket v1.8.10
go/pkg/mod/github.com/tursodatabase/[email protected]/libsql/internal/ws/websockets.go:12:2: reading nhooyr.io/websocket/go.mod at revision v1.8.10: unknown revision v1.8.10
go/pkg/mod/github.com/tursodatabase/[email protected]/libsql/internal/ws/websockets.go:13:2: reading nhooyr.io/websocket/go.mod at revision v1.8.10: unknown revision v1.8.10

This was because libsql-client-go's internal dependency websocket transferred ownership from nhooyr.io/websocket to github.com/coder/websocket. More details available at https://coder.com/blog/websocket.

libsql-client-go has since updated to point to the new path. This PR points to the new version. I have tested that make coverage runs successfully.

@mfridman
Copy link
Collaborator

Thanks for opening a PR, I had queued up another one yesterday to bump the deps and remove go1.23-rc.1 from the matrix. #806, I think we can close this one? Let me know if you're running into any issues with latest.

@ghostwriternr
Copy link
Author

Hey @mfridman! Missed your response here last week, but yes, can confirm your PR resolves the issue. Closing this one. Thanks a bunch!

@ghostwriternr ghostwriternr deleted the upgrade-libsql-client-go branch August 25, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants