Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add submission failed handler #3937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add submission failed handler #3937

wants to merge 1 commit into from

Conversation

amazingdudu
Copy link

Provide a handler when form validation fails。

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 0018223

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 6:25am

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0018223:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

quantizor
quantizor reviewed Apr 10, 2024
View reviewed changes
packages/formik/src/Formik.tsx
@@ -859,6 +863,10 @@ export function useFormik<Values extends FormikValues = FormikValues>({
return onSubmit(state.values, imperativeMethods);
});

const executeSubmitFailed = useEventCallback(() => {
return onSubmitFailed?.(state.errors, imperativeMethods);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap this to stateRef.current.errors? state can be stale sometimes

quantizor
quantizor reviewed Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, can you add at least one unit test and a minor changeset for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor left review comments

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer jaredpalmer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amazingdudu @quantizor