Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: passing all values as the second parameter when calling Field's validate #3882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: passing all values as the second parameter when calling Field's validate #3882

wants to merge 1 commit into from

Conversation

myNameIsDu
Copy link

@myNameIsDu myNameIsDu commented Sep 12, 2023 •
edited
Loading

Close #3874

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d676a73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Minor
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:45am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d676a73:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

@quantizor
Copy link
Collaborator

Generally in favor, could you adjust the documentation and add a changeset? Thanks

@myNameIsDu
Copy link
Author

Yeah, I'll adjust the document later, And I've already added a changeset, But there's another problem

when I executed yarn changeset, It threw an error

image

But I modified baseBranch option in the changeset config.json to be "main", and it worked, So I think maybe we have to add this change

@myNameIsDu
Copy link
Author

I've already adjusted the Field API document, but I'm not sure if there are other places I need to adjust. If there are, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer jaredpalmer is a code owner

@quantizor quantizor Awaiting requested review from quantizor quantizor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

passing all values as the second parameter when calling Field's validate
2 participants
@myNameIsDu @quantizor