Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flutter_login): fix flickering on login transition #4210

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(flutter_login): fix flickering on login transition #4210

merged 2 commits into from
Jul 26, 2024

Conversation

LukasMirbt
Copy link
Contributor

@LukasMirbt LukasMirbt commented Jul 21, 2024 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

Uses FormzSubmissionStatus.inProgressOrSuccess instead of inProgress to reduce flickering when transitioning between pages.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@LukasMirbt LukasMirbt force-pushed the fix/use-in-progress-or-success branch from c311266 to 777d67c Compare July 21, 2024 15:12
@felangel felangel changed the title fix(flutter_login): use inProgressOrSuccess instead of inProgress fix(flutter_login): fix flickering on login transition Jul 26, 2024
@felangel felangel added bug Something isn't working example Example application labels Jul 26, 2024
felangel
felangel approved these changes Jul 26, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contribution! 💙

@felangel felangel merged commit 59d7512 into felangel:master Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@LukasMirbt LukasMirbt

Labels
bug Something isn't working example Example application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasMirbt @felangel