Kuba/ssh/receive exit fix options construct fix/otp 19246/otp 19247 #8854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maria Scott <[email protected]> Co-authored-by: Jan Uhlig <[email protected]>
This was [{active, false}, {reuseaddr,true} | ?GET_OPT(socket_options,
Options)] in ssh_acceptor, which is wrong. For one, it would prevent
the usage of option inet_backend since this option must be the first
in the list. For another, in options given to gen_tcp or ssl, the last
option wins, such that if for example {active, true} was in the list
of given socket options, it would be set to {active, true} despite the
tacked-on {active, false}.
Co-authored-by: Maria Scott <[email protected]>
Co-authored-by: Jan Uhlig <[email protected]>
CT Test Results 2 files 29 suites 17m 58s ⏱️ Results for commit 95307d5. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Maria-12648430
approved these changes
Sep 24, 2024
IngelaAndin
reviewed
Sep 26, 2024
IngelaAndin
reviewed
Sep 26, 2024
IngelaAndin
approved these changes
Sep 27, 2024
690010c
to
95307d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for GH-8223 and also append
{active, false}at the end of socket options.Server supervision tree improvements are planned to be done in other PR.