Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify burst mode protection and non file based logging #8851

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

PragTob
Copy link
Contributor

@PragTob PragTob commented Sep 24, 2024

Reading the docs my impression was that the reasons mentioned for burst mode protection do only apply to file-based logging or at least the examples only do.

Locking to the console is fairly common in cloud-based environments.
I have deactivated the burst mode protection (that had swallowed about 2/3s of our log messages) and the system is running fine without any impact on CPU or memory that I could spot.

So, this is part me wanting to clarify this in the doc but also part me checking in about my understanding of the interplay of this.

Thank you all so much for your work 💚

Reading the docs my impression was that the reasons mentioned
for burst mode protection do only apply to file-based logging or
at least the examples only do.

Locking to the console is fairly common in cloud-based
environments.
I have deactivated the burst mode protection (that had swallowed
about 2/3s of our log messages) and the system is running fine
without any impact on CPU or memory that I could spot.

So, this is part me wanting to clarify this in the doc but also
part me checking in about my understanding of the interplay of
this.
Copy link
Contributor

github-actions bot commented Sep 24, 2024

CT Test Results

    2 files     70 suites   1h 7m 3s ⏱️
1 547 tests 1 303 ✅ 241 💤 3 ❌
1 763 runs  1 487 ✅ 273 💤 3 ❌

For more details on these failures, see this check.

Results for commit 1913013.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@PragTob
Copy link
Contributor Author

PragTob commented Sep 24, 2024

Pretty sure that the test failures here an in the other PRs have nothing to do with the doc only PRs:

interactive_shell_SUITE	tty	[shell_full_queue](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_full_queue.html)	[<](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_full_queue.html#top) [>](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_full_queue.html#end)	6.963s	FAILED	{interactive_shell_SUITE,shell_full_queue,[1638](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.src.html#1638)}
{test_case_failed,nomatch}
843	interactive_shell_SUITE	tty_unicode	[shell_invalid_unicode](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_invalid_unicode.63650.html)	[<](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_invalid_unicode.63650.html#top) [>](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_invalid_unicode.63650.html#end)	0.490s	FAILED	{erpc,call,1368}
{{exception,badarg,[...]},[{erpc,...},{...}|...]}
830	interactive_shell_SUITE	tty_tests	[shell_format](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_format.63170.html)	[<](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_format.63170.html#top) [>](file:https:///home/tobi/Downloads/otptest/make_test_dir/ct_logs/[email protected]_11.41.21/make_test_dir.kernel_test.logs/run.2024-09-24_11.41.50/interactive_shell_suite.shell_format.63170.html#end)	6.015s	FAILED	{erpc,call,1368}
{{exception,badarg,[...]},[{erpc,...},{...}|...]}

@garazdawi garazdawi merged commit 5e6713d into erlang:master Sep 24, 2024
14 of 16 checks passed
@garazdawi
Copy link
Contributor

Thanks!

@PragTob PragTob deleted the log-events-console-vs-file branch September 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants