Let json:decode/3 keep whitespaces #8809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json:decode/3
always stripped leading whitespaces in theRest
binary, which could be problematic if user expected them.E.g
json:decode(<<"foo\n bar">>, ok, #{})
returned:{<<"foo">>, ok, <<"bar">>}
instead of{<<"foo">>, ok, <<"\n bar">>}
.If
Rest
only contains whitespaces they are removed, so that the user can match on empty binary to know if they should continue the decoding loop.E.g
json:decode(<<"foo\n ">>, ok, #{})
still returns:{<<"foo">>, ok, <<>>}