feat(translator): implement access log types #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4341 +/- ##
==========================================
+ Coverage 65.71% 65.82% +0.10%
==========================================
Files 200 200
Lines 24141 24171 +30
==========================================
+ Hits 15865 15911 +46
+ Misses 7140 7126 -14
+ Partials 1136 1134 -2 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Sep 27, 2024
internal/xds/translator/testdata/in/xds-ir/accesslog-als-tcp.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Guy Daich <[email protected]>
zirain
previously approved these changes
Oct 4, 2024
arkodg
reviewed
Oct 8, 2024
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
arkodg
reviewed
Oct 9, 2024
| @@ -0,0 +1,2 @@ | |||
| - ignorePortInHostMatching: true | |||
There was a problem hiding this comment.
lets add a valid xds ir route value so this gets populated properly
zirain
approved these changes
Oct 10, 2024
juwon8891
pushed a commit
to juwon8891/gateway
that referenced
this pull request
Oct 22, 2024
* impl: access log types Signed-off-by: Guy Daich <[email protected]> * clarify docs Signed-off-by: Guy Daich <[email protected]> * add note on default settings override Signed-off-by: Guy Daich <[email protected]> * support default log re-enablement Signed-off-by: Guy Daich <[email protected]> * fix xds test to contain route Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Co-authored-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #3600