-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support inverting header matches for rate limit #4286
feat: support inverting header matches for rate limit #4286
Conversation
b5feec5
to
bb18b2e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4286 +/- ##
=======================================
Coverage 65.71% 65.72%
=======================================
Files 200 200
Lines 24128 24141 +13
=======================================
+ Hits 15856 15866 +10
- Misses 7138 7139 +1
- Partials 1134 1136 +2 ☔ View full report in Codecov by Sentry. |
the PR looks good, can you add some tests in https://github.com/envoyproxy/gateway/tree/main/internal/gatewayapi/testdata & https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata |
5c4a215
to
059134c
Compare
c8357d4
to
e7f4310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
would be great to see some e2e and docs in follow up PRs
can you make linter happy? |
here are the errors
|
Signed-off-by: Rudrakh Panigrahi <[email protected]>
e7f4310
to
5c645de
Compare
Signed-off-by: Rudrakh Panigrahi <[email protected]>
What type of PR is this?
Feature changes for supporting inverting header matches for rate limiting.
What this PR does / why we need it:
Implements API changes proposed in #4176
Which issue(s) this PR fixes:
Ref #2193