Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ForeignExample for OpenJPA #728

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Add ForeignExample for OpenJPA #728

wants to merge 9 commits into from

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Oct 28, 2020 •
edited
Loading

Follow up of #732

  • upgrade OpenJPA to 3.1.3
  • enable "native" SchemaFactory, that create FOREIGN KEYs at database level
  • add test cases

@eolivelli
Copy link
Contributor Author

This is a draft as it depends on snapshot version of OpenJPA

eolivelli
eolivelli commented Oct 31, 2020
View reviewed changes
herddb-thirdparty/openjpa-test/pom.xml
@@ -41,7 +41,7 @@
<dependency>
<groupId>org.apache.openjpa</groupId>
<artifactId>openjpa</artifactId>
<version>3.1.1</version>
<version>3.1.3-SNAPSHOT</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be seen a problematic for a release, but it is needed in order to see the test work.
if we want to cut a release we must revert back to 3.1.2 and comment parts of the test
I hope that with @rmannibucau 's help we could release OpenJPA 3.1.3 soon

eolivelli
eolivelli commented Oct 31, 2020
View reviewed changes
herddb-thirdparty/openjpa/src/main/java/herddb/openjpa/DBDictionary.java
supportsForeignKeys = false;
supportsUniqueConstraints = false;
supportsCascadeDeleteAction = false;
supportsDeferredConstraints = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same change did on OpenJPA 3.1.3-SNAPSHOT on "official" HerdDB dictionary

@eolivelli eolivelli marked this pull request as ready for review October 31, 2020 15:42
@eolivelli eolivelli changed the title Add OpenJPA foreignkey example Fix JDBC Metadata for FKs, fix delimiters for FKs and add more tests about OpenJPA Nov 2, 2020
@eolivelli
Copy link
Contributor Author

For reference this is the bug on OpenJPA
https://issues.apache.org/jira/browse/OPENJPA-2837

I will work on it this week
cc @rmannibucau

@eolivelli
Copy link
Contributor Author

We have to wait for OpenJPA 3.1.3
I have filed this PR with the first part of the fix, without the OpenJPA 3.1.3 upgrade with support for FKs

@eolivelli eolivelli changed the title Fix JDBC Metadata for FKs, fix delimiters for FKs and add more tests about OpenJPA Add ForeignExample for OpenJPA Nov 13, 2020
@eolivelli eolivelli marked this pull request as draft November 13, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegosalvi diegosalvi Awaiting requested review from diegosalvi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eolivelli