-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] pos_payment_method_cashdro #1208
base: 17.0
Are you sure you want to change the base?
Conversation
This module allows to make payments with a Cashdro (https://www.cashdro.com) terminal on the Point of Sale frontend. TT29224
Currently translated at 100.0% (8 of 8 strings) Translation: pos-14.0/pos-14.0-pos_payment_method_cashdro Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_payment_method_cashdro/it/
Overcome floting point issues: https://stackoverflow.com/a/588014 For expample 2.3 * 100 -> 229.99999999999997 TT42574
Currently translated at 100.0% (8 of 8 strings) Translation: pos-14.0/pos-14.0-pos_payment_method_cashdro Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_payment_method_cashdro/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_payment_method_cashdro Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_method_cashdro/
Currently translated at 100.0% (6 of 6 strings) Translation: pos-16.0/pos-16.0-pos_payment_method_cashdro Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_method_cashdro/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbejaoui !
Do you know why the tests are failing? Is it failing because of something overriden in this module?
pos_payment_method_cashdro/static/src/js/payment_cashdro.esm.js
Outdated
Show resolved
Hide resolved
pos_payment_method_cashdro/static/src/js/payment_cashdro.esm.js
Outdated
Show resolved
Hide resolved
/ocabot migration pos_payment_method_cashdro |
The failing test is in the pos_lot_barcode module |
f70597c
to
b668362
Compare
Hi @sbejaoui , I have a problem same as you, do you know the reason? |
Sorry @sbejaoui you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
I have no idea right now, but I’m willing to debug this soon. I’ll let you know |
Thanks, I just realized that when the test case runs |
In the PR tests logs it shows a failing step, not a timeout, that might be related with this module migration:
You can try a temporal commit disable |
No description provided.