ensured building against numpy>=2 #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy 2 introduced quite some changes: - API - deprecated methods - casting behaviour - tolerances in some methods All of the above required both internal changes, but also changes directly related to the tests. The CI script for GA has changed drastically. I am quite annoyed that this requires that much attention, I am constantly battling inconsistent fortran handling and other parts. Now I have changed (again) to setup-fortran. However, this jumps the deployment target for Mac users. Thus bumping up the required OS for Mac users. I hope this won't cause too much trouble. Signed-off-by: Nick Papior <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
===========================================
- Coverage 87.10% 66.23% -20.87%
===========================================
Files 401 401
Lines 51789 51714 -75
===========================================
- Hits 45111 34253 -10858
- Misses 6678 17461 +10783 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
| @@ -711,8 +711,8 @@ | |||
| r = _a.asarray(r) | |||
| s = r.shape[:-1] | |||
| # Convert to spherical coordinates | |||
| n, idx, r, theta, phi = cart2spher(r, theta=m != 0, cos_phi=True, maxR=self.R) | |||
| p = _a.zerosd(n) | |||
| idx, r, theta, phi = cart2spher(r, theta=m != 0, cos_phi=True, maxR=self.R) | |||
Check failure
Code scanning / CodeQL
Mismatch in multiple assignment Error
| r, theta=self.m != 0, cos_phi=True, maxR=self.R | ||
| ) | ||
| p = _a.zerosd(n) | ||
| idx, r, theta, phi = cart2spher(r, theta=self.m != 0, cos_phi=True, maxR=self.R) |
Check failure
Code scanning / CodeQL
Mismatch in multiple assignment Error
Signed-off-by: Nick Papior <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy 2 introduced quite some changes:
All of the above required both internal changes,
but also changes directly related to the tests.
The CI script for GA has changed drastically.
I am quite annoyed that this requires that much
attention, I am constantly battling inconsistent
fortran handling and other parts.
Now I have changed (again) to setup-fortran.
However, this jumps the deployment target for Mac
users. Thus bumping up the required OS for Mac users. I hope this won't cause too much trouble.
isort .andblack .[24.2.0] at top-leveldocs/CHANGELOG.md