Adopt to latest Unikraft core changes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Kuenzer <[email protected]>
Signed-off-by: Simon Kuenzer <[email protected]>
This header is needed to compile `lib/posix-process`. Signed-off-by: Simon Kuenzer <[email protected]>
6c9e266
to
a785211
Compare
mariapana
reviewed
Feb 6, 2024
There was a problem hiding this comment.
When attempting to use newlib for the helloworld app, the following error occurs:
LD helloworld_qemu-x86_64.dbg
/usr/bin/ld: /home/mia/Unikraft/workdir/apps/helloworld/workdir/build/libnewlibc.o: in function `__collate_err':
/home/mia/Unikraft/workdir/apps/helloworld/workdir/build/libnewlibc/origin/newlib-2.5.0.20170922/newlib/libc/posix/collate.c:192: undefined reference to `exit'
collect2: error: ld returned 1 exit status
make[3]: *** [/home/mia/Unikraft/workdir/apps/helloworld/workdir/unikraft/plat/kvm/Linker.uk:54: /home/mia/Unikraft/workdir/apps/helloworld/workdir/build/helloworld_qemu-x86_64.dbg] Error 1
make[2]: *** [Makefile:1170: sub-make] Error 2
make[1]: *** [Makefile:41: _all] Error 2
make[1]: Leaving directory '/home/mia/Unikraft/workdir/apps/helloworld/workdir/unikraft'
make: *** [Makefile:7: all] Error 2
Similar errors occur for different apps as well (for example not being able to find sys/cdefs.h).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates newlib to make it work again with the latest Unikraft version on
staging(at the time of this writing commit46754d7). Please note that still not all Unikraft libraries are compatible with newlib at the moment.