fix: Build folder cleanup #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To speed up the review, I would like to add some comments on my changes |
Jklawreszuk
commented
Jul 11, 2024
There was a problem hiding this comment.
StrideGenerateDoc was changed into StridePublicApi (2c3f881), seems to forgot to add a change here
Jklawreszuk
commented
Jul 11, 2024
Jklawreszuk
commented
Jul 11, 2024
There was a problem hiding this comment.
The script is not used anywhere.The script itself is too simple to be in the source code better to save in user gist
Jklawreszuk
commented
Jul 11, 2024
There was a problem hiding this comment.
The script was used in the XenkoSample.build file (53ce6d3), but was simplied, probably in favor of StrideSamples.sln; unused
|
Cool, thanks a bunch for the notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
PR removes unused files located in build folder. I also fixed BuildXmlDocumentation.bat file
Types of changes
Checklist