Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#245 fixed different python versions #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

layderv
Copy link

@layderv layderv commented Apr 15, 2019

See #245

@zcutlip
Copy link
Collaborator

zcutlip commented Jan 28, 2021

We refactored install.sh a while back. Is this still an issue? If so, can you rebase your patch against master?

Copy link

@basilgello basilgello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to replace sudo invocations with $SUDO

install.sh Outdated
@@ -137,7 +139,8 @@ if [ "${BACKEND_GDB}" -eq 1 ]; then
GDB_PYTHON=$(${GDB} -batch -q --nx -ex 'pi import sys; print(sys.executable)')
GDB_PYTHON="${GDB_PYTHON/%$GDB_PYVER/}${GDB_PYVER}"

install_packages
install_packages $PYVER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will throw a missing python-dev package on Debian bullseye and newer.

Keeping only next line L#143 is enough

install.sh Outdated
@@ -182,7 +185,8 @@ if [ "${BACKEND_LLDB}" -eq 1 ]; then
LLDB_SITE_PACKAGES=$(${LLDB} -Qxb --one-line 'script import site; print(site.getusersitepackages())'|tail -1)
fi

install_packages
install_packages $PYVER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@layderv layderv force-pushed the master branch 2 times, most recently from 7af2acd to 15046c8 Compare June 25, 2021 20:39
@@ -108,7 +108,8 @@ function install_apt {
if [ -z "${SKIP_UPDATE}" ]; then
sudo apt-get update
fi
if echo $PYVER|grep "3\."; then
_PYVER=$1
if echo $_PYVER|grep "3\."; then
sudo apt-get -y install libreadline6-dev python3-dev python3-setuptools python3-yaml python3-pip
else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo -> ${SUDO}

Since in containers there is no sudo typically installed.

@@ -132,7 +133,8 @@ function install_yum {
PARAMS="$PARAMS --refresh"
fi

if echo $PYVER|grep "3\."; then
_PYVER=$1
if echo $_PYVER|grep "3\."; then
sudo $CMD $PARAMS install readline-devel python3-devel python3-setuptools python3-yaml python3-pip
else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link

@basilgello basilgello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace unconditional sudo invocations with ${SUDO}, too. For example, running Voltron in a rootless container is totally fine but there is no sudo nor anybother setuid executable installed.

@layderv
Copy link
Author

layderv commented Jul 8, 2021

Fixed

@basilgello
Copy link

@zcutlip ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants