Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh bdm connection_info after retype #501

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

Scsabiii
Copy link

@Scsabiii Scsabiii commented Jul 3, 2024

Add refresh_connection_info to _update_volume_regular function to refresh connection info after cinder migration.

@Scsabiii Scsabiii changed the title Fcd retype support Refresh bdm connection_info after retype Jul 16, 2024
Copy link

@hemna hemna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nova/api/openstack/compute/volumes.py Outdated Show resolved Hide resolved
nova/tests/unit/api/openstack/compute/test_volumes.py Outdated Show resolved Hide resolved
nova/tests/unit/api/openstack/compute/test_volumes.py Outdated Show resolved Hide resolved
@Scsabiii Scsabiii requested a review from grandchild July 16, 2024 15:03
…e fcd-retype

Add bdm connection_info refresh to _update_volume_regular via calling out to cinder for the new data
We need this use-case for the online-retype from vmdk to fcd
@grandchild grandchild requested a review from hemna July 17, 2024 12:25
Copy link

@dhoeller dhoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Scsabiii Scsabiii merged commit 951c2a5 into stable/xena-m3 Jul 17, 2024
2 checks passed
@Scsabiii Scsabiii deleted the fcd_retype branch July 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants