Support user selected delivery method instead of smtp config. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a convenient way to enable sendmail (instead of using :address => "localhost" as config). Also, when using sendmail directly there is no need for a :from address since sendmail will use an appropriate one automatically (if configured correctly).
|
I stumbled upon the same issue. Working on a fork of this gem, I did not see any reason for the (limiting) indirection when configuring ActionMailer. I fixed it by just removing the indirection, in case you are interested: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a convenient way to enable sendmail (instead of using
:address => "localhost" as config).
Also, when using sendmail directly there is no need for a :from address
since sendmail will use an appropriate one automatically (if configured
correctly).