[BUG] Make name attr of Index fast slow attrs #16270
Conversation
Matt711
added
bug
|
/ok to test |
|
/okay to test |
Matt711
changed the title
| def name(self): | ||
| return self._fsproxy_wrapped._name | ||
|
|
||
|
|
||
| def Index__setattr__(self, name, value): |
There was a problem hiding this comment.
With the usage of _FastSlowAttribute I don't think we need Index__setattr__ anymore.
There was a problem hiding this comment.
I agree, except for MultiIndex.
edit: It might need some more customization because it doesn't just yet without Index__setattr__
There was a problem hiding this comment.
Wouldn't defining names Fastslow attribute for MultiIndex just do the job?
There was a problem hiding this comment.
names attr in Pandas is set with property like this. I think_set_names is not being picked up for some reason
There was a problem hiding this comment.
pd.MultiIndex([]).names = ... isn't doing anything
There was a problem hiding this comment.
No I think we still need Index__setattr__ in Index types. This issue address the problem described here.
There was a problem hiding this comment.
No I think we still need
Index__setattr__in Index types. This issue address the problem described here.
I feel if we do this for one attribute we will have to end up doing the same for every attribute, which is why I think there could be a better approach to solve this problem. Let's pair on this tomorrow ?
|
/ok to test |
|
/ok to test |
Matt711
added
3 - Ready for Review
|
/merge |
Description
Debugging the spike in failures from #16234
Checklist